Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

worker: remove duplicate call #26104

Merged
merged 1 commit into from
Feb 16, 2019
Merged

worker: remove duplicate call #26104

merged 1 commit into from
Feb 16, 2019

Conversation

gireeshpunathil
Copy link
Member

Environment::RunCleanup is invoked twice in a row, remove one.

cc @nodejs/workers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2604/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 14, 2019
@gireeshpunathil gireeshpunathil added the worker Issues and PRs related to Worker support. label Feb 14, 2019
benjamingr
benjamingr approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20790/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2019
@gireeshpunathil
worker: remove duplicate call
006947b 
`Environment::RunCleanup` is invoked twice in a row,
remove one.

PR-URL: nodejs#26104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gireeshpunathil gireeshpunathil removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2019
@gireeshpunathil
Copy link
Member Author

landed as 006947b

@gireeshpunathil gireeshpunathil merged commit 006947b into nodejs:master Feb 16, 2019
addaleax pushed a commit that referenced this pull request Feb 16, 2019
@gireeshpunathil @addaleax
worker: remove duplicate call
ea406a2 
`Environment::RunCleanup` is invoked twice in a row,
remove one.

PR-URL: #26104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gireeshpunathil @rvagg
worker: remove duplicate call
8045e40 
`Environment::RunCleanup` is invoked twice in a row,
remove one.

PR-URL: #26104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gireeshpunathil @nodejs-github-bot @addaleax @jasnell @benjamingr @cjihrig @richardlau