Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

n-api: do not call into JS when that is not allowed #26127

Closed
wants to merge 1 commit into from
Closed

n-api: do not call into JS when that is not allowed #26127

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Check whether calling into JS is allowed before doing so.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
n-api: do not call into JS when that is not allowed
d6a7477 
Check whether calling into JS is allowed before doing so.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2618/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Feb 15, 2019
@addaleax addaleax added worker Issues and PRs related to Worker support. c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. and removed c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Feb 15, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20821/

@nodejs/n-api

mhdawson
mhdawson approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/20823/

@addaleax
Copy link
Member Author

Landed in 441ef4d

@addaleax addaleax closed this Feb 17, 2019
@addaleax addaleax deleted the napi-do-not-call branch February 17, 2019 17:17
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
n-api: do not call into JS when that is not allowed
441ef4d 
Check whether calling into JS is allowed before doing so.

PR-URL: #26127
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
n-api: do not call into JS when that is not allowed
0e7ab0b 
Check whether calling into JS is allowed before doing so.

PR-URL: #26127
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax @rvagg
n-api: do not call into JS when that is not allowed
1ce5e63 
Check whether calling into JS is allowed before doing so.

PR-URL: #26127
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @mhdawson @devsnek