Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: simplify InspectorConsoleCall #26168

Closed
wants to merge 1 commit into from
Closed

src: simplify InspectorConsoleCall #26168

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

(Based on @joyeecheung’s suggestion in #26113)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: simplify InspectorConsoleCall
b7106e1 
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2643/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 17, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20887/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 19, 2019
@addaleax
Copy link
Member Author

Landed in a34a84d

@addaleax addaleax closed this Feb 20, 2019
@addaleax addaleax deleted the simplify-InspectorConsoleCall branch February 20, 2019 15:54
addaleax added a commit that referenced this pull request Feb 20, 2019
@addaleax
src: simplify InspectorConsoleCall
a34a84d 
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
addaleax added a commit that referenced this pull request Feb 21, 2019
@addaleax
src: simplify InspectorConsoleCall
2374e64 
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax @rvagg
src: simplify InspectorConsoleCall
8881c0b 
Instead of a JS object, set the is-in-console-call flag as
a boolean in C++.

PR-URL: #26168
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eugeneo eugeneo eugeneo approved these changes

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @eugeneo @jasnell @joyeecheung @devsnek