Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: remove unnecessary default tmpdir value in test #26177

Closed
wants to merge 1 commit into from
Closed

test: remove unnecessary default tmpdir value in test #26177

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 18, 2019

tmpdir.path will never be falsy so there is no need to guard against
that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove unnecessary default tmpdir value in test
289d470 
`tmpdir.path` will never be falsy so there is no need to guard against
that.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2652/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2019
@Trott
Copy link
Member Author

Trott commented Feb 18, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20848/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2019
@Trott
Copy link
Member Author

Trott commented Feb 20, 2019

Landed in d2c29bd

@Trott Trott closed this Feb 20, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 20, 2019
@Trott
test: remove unnecessary default tmpdir value in test
d2c29bd 
`tmpdir.path` will never be falsy so there is no need to guard against
that.

PR-URL: nodejs#26177
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
addaleax pushed a commit that referenced this pull request Feb 21, 2019
@Trott @addaleax
test: remove unnecessary default tmpdir value in test
a6be873 
`tmpdir.path` will never be falsy so there is no need to guard against
that.

PR-URL: #26177
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: remove unnecessary default tmpdir value in test
818b280 
`tmpdir.path` will never be falsy so there is no need to guard against
that.

PR-URL: #26177
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@Trott Trott deleted the refactor-test-pipe-file branch January 13, 2022 22:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @danbev @jasnell @cjihrig @richardlau @starkwang