Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tools: update ESLint to 5.14.1 #26190

Merged
merged 1 commit into from
Feb 20, 2019
Merged

tools: update ESLint to 5.14.1 #26190

merged 1 commit into from
Feb 20, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 18, 2019

Update ESLint to 5.14.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 18, 2019
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2658/pipeline

@danbev
Copy link
Contributor

danbev commented Feb 19, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20877/

EDIT(cjihrig): CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@cjihrig
tools: update ESLint to 5.14.1
14c089b 
Update ESLint to 5.14.1

PR-URL: nodejs#26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 14c089b into nodejs:master Feb 20, 2019
@cjihrig cjihrig deleted the eslint branch February 20, 2019 17:27
addaleax pushed a commit that referenced this pull request Feb 21, 2019
@cjihrig @addaleax
tools: update ESLint to 5.14.1
6709dfa 
Update ESLint to 5.14.1

PR-URL: #26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
tools: update ESLint to 5.14.1
dff0149 
Update ESLint to 5.14.1

PR-URL: #26190
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@refack refack refack approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @danbev @refack @Trott @richardlau @BridgeAR