doc: revise deprecation level explanations in Collaborator Guide #26197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise deprecation level explanations for scanability and ease of understanding.
richardlau
approved these changes
Feb 19, 2019
vsemozhetbyt
approved these changes
Feb 19, 2019
vsemozhetbyt
added
deprecations
mihalskiy
approved these changes
Feb 19, 2019
hiroppy
approved these changes
Feb 19, 2019
BridgeAR
approved these changes
Feb 20, 2019
| * End-of-life | ||
| * The API is no longer subject to the semantic versioning rules. | ||
| * Backward-incompatible changes including complete removal of such APIs may | ||
| occur at any time. |
There was a problem hiding this comment.
Just a suggestion: should be state that End-of-life mostly means it is removed?
jasnell
approved these changes
Feb 21, 2019
|
Landed in 70b13c2 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 21, 2019
Revise deprecation level explanations for scanability and ease of understanding. PR-URL: nodejs#26197 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 21, 2019
Revise deprecation level explanations for scanability and ease of understanding. PR-URL: #26197 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Revise deprecation level explanations for scanability and ease of understanding. PR-URL: #26197 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise deprecation level explanations for scanability and ease of
understanding.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes