Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: remove unused macro in node_http2.h #26204

Closed
wants to merge 1 commit into from
Closed

src: remove unused macro in node_http2.h #26204

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Feb 19, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/20911/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@gengjiawen
Copy link
Member Author

@BridgeAR Can you re-run the failing build ? Thanks.

@gengjiawen
Copy link
Member Author

@danbev Can you import this pr, #26218 and #26242 ? Thanks.

@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21073/

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25066/

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

Landed in 453ed05

@addaleax addaleax closed this Mar 1, 2019
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen @addaleax
src: remove unused macro in node_http2.h
453ed05 
PR-URL: #26204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@gengjiawen @addaleax
src: remove unused macro in node_http2.h
4df82f0 
PR-URL: #26204
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @BridgeAR @addaleax @jasnell @cjihrig @nodejs-github-bot