Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: simplify test-api-nohooks.js #26217

Merged
merged 1 commit into from
Feb 22, 2019
Merged

test: simplify test-api-nohooks.js #26217

merged 1 commit into from
Feb 22, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2673/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 20, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 20, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 20, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20915/

EDIT: CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@cjihrig
test: simplify test-api-nohooks.js
fac40db 
PR-URL: nodejs#26217
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit fac40db into nodejs:master Feb 22, 2019
@cjihrig cjihrig deleted the test branch February 22, 2019 18:43
addaleax pushed a commit that referenced this pull request Feb 25, 2019
@cjihrig @addaleax
test: simplify test-api-nohooks.js
0daed8e 
PR-URL: #26217
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
test: simplify test-api-nohooks.js
bc11415 
PR-URL: #26217
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. report Issues and PRs related to process.report. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @richardlau @BridgeAR