build: tidy up comments in create_expfile.sh
#26220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Feb 20, 2019
Trott
approved these changes
Feb 20, 2019
richardlau
added
the
author ready
cjihrig
approved these changes
Feb 20, 2019
BridgeAR
approved these changes
Feb 20, 2019
jasnell
approved these changes
Feb 21, 2019
Fixes spelling, adds punctuation and rewords some sentences for readability in the comments of `tools/create_expfile.sh`. PR-URL: nodejs#26220 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
force-pushed
the
create_expfile-nits
branch
from
bf6e8b9 to
4804a18
Compare
|
Landed in 4804a18. |
addaleax
pushed a commit
that referenced
this pull request
Feb 25, 2019
Fixes spelling, adds punctuation and rewords some sentences for readability in the comments of `tools/create_expfile.sh`. PR-URL: #26220 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Fixes spelling, adds punctuation and rewords some sentences for readability in the comments of `tools/create_expfile.sh`. PR-URL: #26220 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spelling, adds punctuation and rewords some sentences for
readability in the comments of
tools/create_expfile.sh.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes