Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: remove dead inspector code #26295

Closed
wants to merge 1 commit into from
Closed

src: remove dead inspector code #26295

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This was overlooked in c583245.

Refs: #26137

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Feb 24, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21067/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 1, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21080/

@addaleax
Copy link
Member Author

addaleax commented Mar 1, 2019

Landed in b0b370c

@addaleax addaleax closed this Mar 1, 2019
@addaleax addaleax deleted the inspector-dead-code branch March 1, 2019 20:48
addaleax added a commit that referenced this pull request Mar 1, 2019
@addaleax
src: remove dead inspector code
b0b370c 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
@addaleax
src: remove dead inspector code
30f0a3b 
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @tniessen