Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: remove cast for unsupported openssl #26305

Closed
wants to merge 1 commit into from
Closed

src: remove cast for unsupported openssl #26305

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.

To be clear, I mean don't support even when configured against an external openssl.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github
src: remove cast for unsupported openssl
983ef18 
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.
@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 25, 2019
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21040/

@sam-github
Copy link
Contributor Author

Landed in 3f31c88

@sam-github sam-github closed this Feb 28, 2019
@sam-github sam-github deleted the fix-obsolete-cast branch February 28, 2019 21:27
sam-github added a commit that referenced this pull request Feb 28, 2019
@sam-github
src: remove cast for unsupported openssl
3f31c88 
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.

PR-URL: #26305
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@sam-github @addaleax
src: remove cast for unsupported openssl
d6759db 
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.

PR-URL: #26305
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-github @nodejs-github-bot @bnoordhuis @jasnell @thefourtheye @cjihrig