Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: use EVPKeyPointer in more places #26632

Closed
wants to merge 1 commit into from
Closed

src: use EVPKeyPointer in more places #26632

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

Apologies, the diff is kind of hard to read in places. Might be easier side-to-side.

@bnoordhuis
src: use EVPKeyPointer in more places
5eea737 
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!
@nodejs-github-bot
Copy link
Collaborator

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2891/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 13, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21518/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2019
@danbev
Copy link
Contributor

danbev commented Mar 18, 2019

Landed in 3610155.

@danbev danbev closed this Mar 18, 2019
danbev pushed a commit that referenced this pull request Mar 18, 2019
@bnoordhuis @danbev
src: use EVPKeyPointer in more places
3610155 
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

PR-URL: #26632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@bnoordhuis @targos
src: use EVPKeyPointer in more places
413b9ef 
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

PR-URL: nodejs#26632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@bnoordhuis @targos
src: use EVPKeyPointer in more places
15ec381 
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

PR-URL: #26632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bnoordhuis @nodejs-github-bot @BridgeAR @danbev @jasnell @cjihrig @tniessen @JungMinu @mihalskiy