Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

report: remove duplicate TIME_TYPE #26708

Closed
wants to merge 1 commit into from
Closed

report: remove duplicate TIME_TYPE #26708

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2938/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 16, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Mar 16, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21601/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 18, 2019

Green resume CI: https://ci.nodejs.org/job/node-test-pull-request/21626/

@danbev
Copy link
Contributor

danbev commented Mar 20, 2019

Landed in d933cc4.

@danbev danbev closed this Mar 20, 2019
danbev pushed a commit that referenced this pull request Mar 20, 2019
@cjihrig @danbev
report: remove duplicate TIME_TYPE
d933cc4 
PR-URL: #26708
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig deleted the time-type branch March 22, 2019 03:10
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@cjihrig @targos
report: remove duplicate TIME_TYPE
3a98a8b 
PR-URL: nodejs#26708
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@cjihrig @targos
report: remove duplicate TIME_TYPE
5b8eae4 
PR-URL: #26708
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @BridgeAR @danbev @jasnell @addaleax @richardlau