Skip to content

build: update configure for Node.js 12 #26719

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

richardlau
Copy link
Member

Refs: #26714

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 17, 2019
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 17, 2019
@richardlau
Copy link
Member Author

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

@richardlau
Copy link
Member Author

richardlau commented Mar 17, 2019

@mscdex
Copy link
Contributor

mscdex commented Mar 17, 2019

If this is just a warning, perhaps the language in the commit message is a bit too strong?

@richardlau
Copy link
Member Author

If this is just a warning, perhaps the language in the commit message is a bit too strong?

¯\_(ツ)_/¯ It's the language we used in previous commits (79773f8, b4f59a7). I used build rather than doc as the subsystem as I felt it's more appropriate).

@refack
Copy link
Contributor

refack commented Mar 17, 2019

Note that this check is a warning and doesn't prevent you attempting to use older compilers.

IMHO that makes this not semver-major, just a "don't land on X"

@targos
Copy link
Member

targos commented Mar 17, 2019

I agree. #26714 being semver-major is enough

@richardlau richardlau added dont-land-on-v6.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 17, 2019
@richardlau richardlau changed the title build: update configure to require g++ 6.3.0 build: update configure for Node.js 12 Mar 21, 2019
@richardlau
Copy link
Member Author

richardlau commented Mar 21, 2019

Updated the commit message and clang level. PTAL.

New CI: https://ci.nodejs.org/job/node-test-pull-request/21714/ (✔️)

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@refack
Copy link
Contributor

refack commented Mar 22, 2019

I think it's good to capture the state of things with this PR right now.
I'm hoping to break everything in #26725 anyway 🤞

Update supported level of gcc to 6.3.0 and clang to 8.0.0.

Refs: nodejs#26714

PR-URL: nodejs#26719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau richardlau merged commit 41ba699 into nodejs:master Mar 22, 2019
@richardlau
Copy link
Member Author

Landed in 41ba699.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants