Skip to content

src: only open HandleScope when necessary #26734

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: only open HandleScope when necessary #26734

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2960/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 18, 2019
@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21717/

@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21724/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@addaleax
Copy link
Member Author

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/21720/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 21, 2019
@addaleax @BridgeAR
src: only open HandleScope when necessary
bca23f2 
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR
Copy link
Member

Landed in bca23f2 🎉

@BridgeAR BridgeAR closed this Mar 21, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@addaleax @targos
src: only open HandleScope when necessary
12c51ba 
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@addaleax @targos
src: only open HandleScope when necessary
14c3af7 
PR-URL: #26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @danbev @BridgeAR @apapirovski @jasnell @cjihrig