Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

lib: remove usage of require('util') #26773

Closed
wants to merge 1 commit into from
Closed

lib: remove usage of require('util') #26773

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 19, 2019

Remove usage of public require('util') in
internal/child_process.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
lib: remove usage of require('util')
9fe5304 
Remove usage of public require('util') in
`internal/child_process`.

Refs: nodejs#26546
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Mar 19, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21658/

@dnlup
Copy link
Contributor Author

dnlup commented Mar 19, 2019

@targos @ZYSzys Should I do something about the node-test-binary-windows that is failing?

@targos
Copy link
Member

targos commented Mar 19, 2019

@dnlup No, it's fine :) . The machine was disconnected while it was running the tests.

@ZYSzys
Copy link
Member

ZYSzys commented Mar 19, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21686/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 21, 2019

Landed in 1500e5d 🎉

Thank you for your contribution !

@ZYSzys ZYSzys closed this Mar 21, 2019
ZYSzys pushed a commit that referenced this pull request Mar 21, 2019
@dnlup @ZYSzys
lib: remove usage of require('util')
1500e5d 
Remove usage of public require('util') in
`internal/child_process`.

Refs: #26546

PR-URL: #26773
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@joyeecheung joyeecheung mentioned this pull request Mar 23, 2019
Closed
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@dnlup @targos
lib: remove usage of require('util')
225b249 
Remove usage of public require('util') in
`internal/child_process`.

Refs: nodejs#26546

PR-URL: nodejs#26773
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@dnlup @targos
lib: remove usage of require('util')
e916a2a 
Remove usage of public require('util') in
`internal/child_process`.

Refs: #26546

PR-URL: #26773
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
@dnlup dnlup deleted the util_internal_child_process branch January 10, 2020 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnlup @ZYSzys @targos @nodejs-github-bot