Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

errors: remove usage of require('util') #26781

Closed
wants to merge 1 commit into from
Closed

errors: remove usage of require('util') #26781

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 19, 2019

Remove internal usage of require('util').inspect in lib/internal/error-serdes.js.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@dnlup
errors: remove usage of require('util')
4aae313 
Remove internal usage of `require('util').inspect`.

Refs: nodejs#26546
@dnlup dnlup force-pushed the util_internal_error-serdes branch from 9a79fea to 4aae313 Compare March 22, 2019 17:03
@dnlup dnlup changed the title lib: remove usage of require('util') errors: remove usage of require('util') Mar 22, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21863/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21885/

@danbev
Copy link
Contributor

danbev commented Mar 26, 2019

Landed in 553c876.

@danbev danbev closed this Mar 26, 2019
danbev pushed a commit that referenced this pull request Mar 26, 2019
@dnlup @danbev
errors: remove usage of require('util')
553c876 
Remove internal usage of `require('util').inspect`.

PR-URL: #26781
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 26, 2019
@dnlup @BethGriggs
errors: remove usage of require('util')
ed1c51a 
Remove internal usage of `require('util').inspect`.

PR-URL: #26781
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@dnlup @targos
errors: remove usage of require('util')
bab0241 
Remove internal usage of `require('util').inspect`.

PR-URL: nodejs#26781
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@dnlup @targos
errors: remove usage of require('util')
9a5c149 
Remove internal usage of `require('util').inspect`.

PR-URL: #26781
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
@dnlup dnlup deleted the util_internal_error-serdes branch January 10, 2020 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danbev danbev danbev approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnlup @BridgeAR @nodejs-github-bot @danbev