Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

worker: remove usage of require('util')  #26810

Closed
wants to merge 1 commit into from
Closed

worker: remove usage of require('util')  #26810

wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Remove the usage of public require('util').
Use require('internal/util/inspect').inspect instead of require('util').inspect.
Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Mar 20, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21713/

@ZYSzys
Copy link
Member

ZYSzys commented Mar 21, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/21719/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 22, 2019

Landed in 01a1296 🎉

@ZYSzys ZYSzys closed this Mar 22, 2019
pull bot pushed a commit to SimenB/node that referenced this pull request Mar 22, 2019
@toshi1127 @ZYSzys
worker: remove usage of require('util')
01a1296 
PR-URL: nodejs#26810
Refs: nodejs#26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Mar 22, 2019
Closed
Closed
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127 @targos
worker: remove usage of require('util')
cf5cb8d 
PR-URL: #26810
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127 @targos
worker: remove usage of require('util')
44450ef 
PR-URL: #26810
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@toshi1127 @ZYSzys @jasnell @addaleax @targos @BridgeAR @nodejs-github-bot