doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #26821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-github
added
tls
sam-github
force-pushed
the
doc-default-max-min
branch
from
cbf6a3a to
7415693
Compare
bnoordhuis
approved these changes
Mar 20, 2019
jasnell
approved these changes
Mar 21, 2019
cjihrig
approved these changes
Mar 22, 2019
BridgeAR
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
|
Landed in d989e20 |
sam-github
added a commit
that referenced
this pull request
Mar 25, 2019
PR-URL: #26821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 26, 2019
PR-URL: #26821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
IIUC this should land with or after #26951 |
|
will cherry pick onto the backport for tls1.3 |
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Apr 1, 2019
PR-URL: nodejs#26821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Apr 11, 2019
PR-URL: nodejs#26821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Apr 23, 2019
|
This looks like it went out in 11.15.0, so I'm going to change |
|
Looks like DEFAULT_MIN_VERSION was in 10.16.0 but no documentation is in 10.16.0 for it. Does this need a v10.x backport? Cherry-pick? Neither? @sam-github @BethGriggs |
|
(Refs: #28758. That should be closed once this is in 10.x-staging, I suppose.) |
|
@nitinsurana do you have time to backport the 11.x version of this, fa6f0f1, to 10.x? It would be fairly straight-forward, but all references to TLSv1.3 would have to be removed. I added the various labels, but don't know when this will hit the top of my TODO list. |
|
@sam-github Sure; let me give it a try. |
ckarande
added a commit
to ckarande/node
that referenced
this pull request
Jul 23, 2019
Add documentation for tls.DEFAULT_MAX_VERSION and tls.DEFAULT_MIN_VERSION, which existed in v10.6.0 Fixes: nodejs#28758 Refs: nodejs#26821
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes