test: cover napi_get/set/has_named_property() #26947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
napi-get-set-has-named-property-test
branch
from
40b2a69 to
e4005e5
Compare
Add test coverage for these N-APIs. PR-URL: nodejs#26947
gabrielschulhof
force-pushed
the
napi-get-set-has-named-property-test
branch
from
e4005e5 to
48b9bfc
Compare
danbev
approved these changes
Apr 1, 2019
|
|
||
| NAPI_ASSERT(env, argc >= 2, "Wrong number of arguments"); | ||
|
|
||
| napi_valuetype valuetype0; |
There was a problem hiding this comment.
Nit: Perhaps it would be more consistent to name the NAPI variables like value_type0 instead of valuetype0, like is done for other variables like key_length above. Or is this intentionally done for the NAPI types?
BridgeAR
added
the
author ready
|
Landed in baa54a5. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 5, 2019
Add test coverage for these N-APIs. PR-URL: #26947 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for these N-APIs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes