esm: use primordials #26954
Closed
esm: use primordials #26954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted uses of Object and Map to use frozen built in primordials.
|
Can we fastrack please? |
targos
approved these changes
Mar 28, 2019
BridgeAR
approved these changes
Mar 28, 2019
BridgeAR
added
the
author ready
guybedford
approved these changes
Mar 28, 2019
devsnek
approved these changes
Mar 28, 2019
joyeecheung
approved these changes
Mar 30, 2019
|
Landed in 7a54709 |
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Converted uses of Object and Map to use frozen built in primordials. PR-URL: #26954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Converted uses of Object and Map to use frozen built in primordials. PR-URL: #26954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted uses of Object and Map to use frozen built
in primordials.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes