Skip to content

deps: patch V8 to 7.4.288.18 #27066

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

deps: patch V8 to 7.4.288.18 #27066

merged 2 commits into from
Apr 5, 2019

Conversation

targos
Copy link
Member

@targos targos commented Apr 3, 2019

Refs: v8/v8@7.4.288.13...7.4.288.17

@nodejs/v8-update

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3151

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 3, 2019
@targos targos added dont-land-on-v10.x and removed v8 engine Issues and PRs related to the V8 dependency. labels Apr 3, 2019
@targos
Copy link
Member Author

targos commented Apr 3, 2019

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2209/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22158/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22219/

@targos targos changed the title deps: patch V8 to 7.4.288.17 deps: patch V8 to 7.4.288.18 Apr 5, 2019
@targos
Copy link
Member Author

targos commented Apr 5, 2019

Updated to 7.4.288.18. I need at least one more approval.

@targos
Copy link
Member Author

targos commented Apr 5, 2019

New V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2213/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22221/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22223/

refack
refack approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

targos added 2 commits April 5, 2019 08:45
@targos @refack
deps: patch V8 to 7.4.288.17
c1d61f2 
Refs: v8/v8@7.4.288.13...7.4.288.17

PR-URL: nodejs#27066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos @refack
deps: patch V8 to 7.4.288.18
135b79a 
Refs: v8/v8@7.4.288.17...7.4.288.18

PR-URL: nodejs#27066
Refs: v8/v8@7.4.288.13...7.4.288.17
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack
Copy link
Contributor

refack commented Apr 5, 2019 •
edited
Loading

Landed in c86883c...135b79a31d51939d46b68eaea5249e28c7f67757

@refack refack merged commit 135b79a into nodejs:master Apr 5, 2019
@targos targos deleted the v8-patch branch April 5, 2019 12:58
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@refack refack refack approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @refack @cjihrig