doc: link bigint type to MDN instead of proposal #27101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
4 tasks
BridgeAR
approved these changes
Apr 5, 2019
BridgeAR
added
the
author ready
lpinca
approved these changes
Apr 5, 2019
addaleax
approved these changes
Apr 5, 2019
ZYSzys
approved these changes
Apr 6, 2019
jasnell
approved these changes
Apr 6, 2019
cjihrig
approved these changes
Apr 7, 2019
|
Landed in 1afec97 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 7, 2019
PR-URL: #27101 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesIt is not an ideal solution yet:
bigintas a new primitive currently absent in the MDN section we usually link primitives to, so we need to refer to a global object which may be a bit confusing. But maybe this is better than to link to the proposal now.