Skip to content

lib: fix outdated comment #27122

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lib: fix outdated comment #27122

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: 7e2088f

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3190

@vsemozhetbyt vsemozhetbyt added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 7, 2019
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@danbev danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2019
@danbev
Copy link
Contributor

danbev commented Apr 8, 2019

Landed in 5a8c55f.

@danbev danbev closed this Apr 8, 2019
danbev pushed a commit that referenced this pull request Apr 8, 2019
@vsemozhetbyt @danbev
lib: fix outdated comment
5a8c55f 
PR-URL: #27122
Refs: 7e2088f
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the lib-node.js-comment branch April 8, 2019 14:11
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @nodejs-github-bot @danbev @lpinca @cjihrig @BridgeAR