test: simplify tests by using assert.rejects #27123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `assert.rejects` to test error cases. This simplifies the test.
This verifies that the test actually rejects at this point by using `assert.rejects` instead of `try / catch`.
addaleax
approved these changes
Apr 7, 2019
BridgeAR
added
the
author ready
lpinca
approved these changes
Apr 7, 2019
hiroppy
approved these changes
Apr 7, 2019
jasnell
approved these changes
Apr 8, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 10, 2019
Use `assert.rejects` to test error cases. This simplifies the test. PR-URL: nodejs#27123 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 10, 2019
This verifies that the test actually rejects at this point by using `assert.rejects` instead of `try / catch`. PR-URL: nodejs#27123 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the commit descriptions for details.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes