-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
lib,src,doc: add --heapsnapshot-signal CLI flag #27133
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @joyeecheung's comment addressed
Does this work on Windows? (I'm guessing not, at least based on the equivalent test in node/test/report/test-report-config.js Lines 63 to 87 in cc4e8e0
|
e89e9d6
to
2520bf7
Compare
CI: https://ci.nodejs.org/job/node-test-pull-request/22395/ EDIT(cjihrig): CI was green. |
This flag allows heap snapshots to be captured without modifying application code. PR-URL: nodejs#27133 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This flag allows heap snapshots to be captured without modifying application code. IMO, this is a big part of the "heapdump in core" use case.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes