build: fix test failures not failing Travis builds #27176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
build
|
Second commit is temporary to check Travis correctly fails on a test failure. Will remove once confirmed. Edit: https://travis-ci.com/nodejs/node/jobs/191826848 failed (as expected 🎉 ) |
gengjiawen
approved these changes
Apr 10, 2019
joyeecheung
approved these changes
Apr 10, 2019
richardlau
added
the
author ready
mihalskiy
approved these changes
Apr 10, 2019
ZYSzys
approved these changes
Apr 10, 2019
BethGriggs
approved these changes
Apr 10, 2019
addaleax
approved these changes
Apr 10, 2019
lpinca
approved these changes
Apr 10, 2019
The exit code of the make command used to execute tests was being lost after being piped through to grep.
|
Rebased to fix merge conflict. Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3235/ |
JungMinu
approved these changes
Apr 12, 2019
|
Landed in 7b0d867. |
richardlau
added a commit
that referenced
this pull request
Apr 12, 2019
The exit code of the make command used to execute tests was being lost after being piped through to grep. PR-URL: #27176 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
1 task
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code of the make command used to execute tests was being lost
after being piped through to grep.
Refs: #25947 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes