worker: improve coverage #27230
Closed
worker: improve coverage #27230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the worker coverage by using `internal/assert` instead of relying on `assert` in case a faulty worker message type is received.
addaleax
approved these changes
Apr 14, 2019
richardlau
approved these changes
Apr 14, 2019
ZYSzys
approved these changes
Apr 15, 2019
ZYSzys
added
author ready
jasnell
approved these changes
Apr 15, 2019
|
Landed in d070f5d 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 17, 2019
This improves the worker coverage by using `internal/assert` instead of relying on `assert` in case a faulty worker message type is received. PR-URL: #27230 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the worker coverage by using
internal/assertinsteadof relying on
assertin case a faulty worker message type isreceived (AFAIK this is only set internally, if it's public, this should be replaced with a test).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes