Skip to content

worker: simplify filename checks #27233

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

worker: simplify filename checks #27233

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Replace a couple of checks with a single regular expression.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
worker: simplify filename checks
cffb498 
Replace a couple of checks with a single regular expression.
@BridgeAR BridgeAR requested a review from addaleax April 14, 2019 23:56
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3254

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Apr 14, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22448/

@ZYSzys
Copy link
Member

ZYSzys commented Apr 17, 2019

Landed in 5450e48 🎉

@ZYSzys ZYSzys closed this Apr 17, 2019
ZYSzys pushed a commit that referenced this pull request Apr 17, 2019
@BridgeAR @ZYSzys
worker: simplify filename checks
5450e48 
Replace a couple of checks with a single regular expression.

PR-URL: #27233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the simpler-filename-check branch January 20, 2020 12:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @ZYSzys @jasnell @addaleax @richardlau