src: split per-process initialization and teardown routines #27276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes it possible to instantiate NodeMainInstance in a separate target and use it to e.g. create snapshot.
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Apr 17, 2019
|
Can I have another review please? @nodejs/process |
2 tasks
addaleax
approved these changes
Apr 20, 2019
|
Landed in 5356b4a |
joyeecheung
added a commit
that referenced
this pull request
Apr 20, 2019
This patch makes it possible to instantiate NodeMainInstance in a separate target and use it to e.g. create snapshot. PR-URL: #27276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes