test: remove flaky designation for test-cli-node-options #27305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failure is not platform-specific and is the result of manual/human error. Some improvements may be possible, but there is nothing fundamentally unsound about the test insofar as when it fails in CI, there is a problem on the host that needs to be addressed and not an inherent issue with the test. Refs: nodejs#25028 (comment) Closes: nodejs#25028
addaleax
approved these changes
Apr 19, 2019
cjihrig
approved these changes
Apr 19, 2019
Trott
added
the
author ready
|
Landed in e37eee2 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 21, 2019
The test failure is not platform-specific and is the result of manual/human error. Some improvements may be possible, but there is nothing fundamentally unsound about the test insofar as when it fails in CI, there is a problem on the host that needs to be addressed and not an inherent issue with the test. Refs: nodejs#25028 (comment) Closes: nodejs#25028 PR-URL: nodejs#27305 Fixes: nodejs#25028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failure is not platform-specific and is the result of
manual/human error. Some improvements may be possible, but there is
nothing fundamentally unsound about the test insofar as when it fails in
CI, there is a problem on the host that needs to be addressed and not an
inherent issue with the test.
Refs: #25028 (comment)
Closes: #25028
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes