test: increase coverage in lib/internal/dns/promises.js #27330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for the only uncovered code in lib/internal/dns/promises.js.
ZYSzys
approved these changes
Apr 21, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Apr 21, 2019
|
Landed in eac8f50 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 23, 2019
Add a test for the only uncovered code in lib/internal/dns/promises.js. PR-URL: nodejs#27330 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
Add a test for the only uncovered code in lib/internal/dns/promises.js. PR-URL: #27330 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for the only uncovered code in lib/internal/dns/promises.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes