test: make test-worker-esm-missing-main more robust #27340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-worker-esm-missing-main failed in CI recently in a way that suggests that maybe the `does-not-exist.js` file did in fact exist. Maybe that isn't what happened at all, but let's rule it out by changing the use of `does-not-exist.js` from a file expected to be missing from the current working directory to a file in the temp directory, which the test will remove and recreate at the outset.
|
Ref: https://ci.nodejs.org/job/node-test-commit-aix/22707/nodes=aix61-ppc64/console 00:19:40 not ok 2201 parallel/test-worker-esm-missing-main
00:19:40 ---
00:19:40 duration_ms: 1.226
00:19:40 severity: fail
00:19:40 exitcode: 1
00:19:40 stack: |-
00:19:40 Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
00:19:40 at Object.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:339:10)
00:19:40 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-worker-esm-missing-main.js:10:27)
00:19:40 at Module._compile (internal/modules/cjs/loader.js:759:30)
00:19:40 at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
00:19:40 at Module.load (internal/modules/cjs/loader.js:628:32)
00:19:40 at Function.Module._load (internal/modules/cjs/loader.js:555:12)
00:19:40 at Function.Module.runMain (internal/modules/cjs/loader.js:826:10)
00:19:40 at internal/main/run_main_module.js:17:11
00:19:40 ... |
lpinca
approved these changes
Apr 22, 2019
BethGriggs
approved these changes
Apr 23, 2019
Trott
added
the
author ready
|
Landed in 9b982fe |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 24, 2019
test-worker-esm-missing-main failed in CI recently in a way that suggests that maybe the `does-not-exist.js` file did in fact exist. Maybe that isn't what happened at all, but let's rule it out by changing the use of `does-not-exist.js` from a file expected to be missing from the current working directory to a file in the temp directory, which the test will remove and recreate at the outset. PR-URL: nodejs#27340 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
test-worker-esm-missing-main failed in CI recently in a way that suggests that maybe the `does-not-exist.js` file did in fact exist. Maybe that isn't what happened at all, but let's rule it out by changing the use of `does-not-exist.js` from a file expected to be missing from the current working directory to a file in the temp directory, which the test will remove and recreate at the outset. PR-URL: #27340 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-worker-esm-missing-main failed in CI recently in a way that
suggests that maybe the
does-not-exist.jsfile did in fact exist.Maybe that isn't what happened at all, but let's rule it out by changing
the use of
does-not-exist.jsfrom a file expected to be missing fromthe current working directory to a file in the temp directory, which the
test will remove and recreate at the outset.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes