Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: converting NghttpError to string in HTTP2 module #27506

Closed
wants to merge 1 commit into from
Closed

test: converting NghttpError to string in HTTP2 module #27506

wants to merge 1 commit into from

Conversation

rpgeeganage
Copy link
Contributor

This unit test is for converting NghttpError instance to string using toString() function in NghttpError class

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2019
@rpgeeganage
Copy link
Contributor Author

@BridgeAR , do you think this test case is valid?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22911/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22912/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2019
@ZYSzys
Copy link
Member

ZYSzys commented May 4, 2019

Landed in eda4d3c 🎉.

@ZYSzys ZYSzys closed this May 4, 2019
ZYSzys pushed a commit that referenced this pull request May 4, 2019
@rpgeeganage @ZYSzys
test: converting NghttpError to string in HTTP2 module
eda4d3c 
PR-URL: #27506
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 5, 2019
@rpgeeganage @targos
test: converting NghttpError to string in HTTP2 module
ca720b3 
PR-URL: #27506
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rpgeeganage @nodejs-github-bot @ZYSzys @Trott @BridgeAR