Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: format correction for experimental loader hooks #27537

Closed
wants to merge 1 commit into from
Closed

doc: format correction for experimental loader hooks #27537

wants to merge 1 commit into from

Conversation

dnalborczyk
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 2, 2019
@dnalborczyk dnalborczyk changed the title doc: format correction for experimental loader hooks. doc: format correction for experimental loader hooks May 2, 2019
@Trott
Copy link
Member

Trott commented May 5, 2019

@nodejs/modules-active-members

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2019
@BridgeAR
Copy link
Member

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3498/

@danbev
Copy link
Contributor

danbev commented May 14, 2019

Landed in 523a9fb.

@danbev danbev closed this May 14, 2019
danbev pushed a commit that referenced this pull request May 14, 2019
@dnalborczyk @danbev
doc: format correction for experimental loader hooks
523a9fb 
PR-URL: #27537
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 14, 2019
@dnalborczyk @targos
doc: format correction for experimental loader hooks
da4a379 
PR-URL: #27537
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@dnalborczyk dnalborczyk deleted the patch-1 branch July 31, 2019 14:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@jkrems jkrems jkrems approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dnalborczyk @Trott @BridgeAR @danbev @GeoffreyBooth @jkrems @nodejs-github-bot