Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: remove extra semicolons after macros #27579

Closed
wants to merge 1 commit into from
Closed

src: remove extra semicolons after macros #27579

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 6, 2019
addaleax
addaleax reviewed May 6, 2019
View reviewed changes
addaleax
addaleax approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22995/

@ZYSzys
Copy link
Member

ZYSzys commented May 12, 2019

Landed in 1d31c68 🎉

@ZYSzys ZYSzys closed this May 12, 2019
ZYSzys pushed a commit that referenced this pull request May 12, 2019
@gengjiawen @ZYSzys
src: remove extra semicolons after macros
1d31c68 
PR-URL: #27579
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@gengjiawen gengjiawen deleted the extra-semi branch May 12, 2019 13:28
targos pushed a commit that referenced this pull request May 13, 2019
@gengjiawen @targos
src: remove extra semicolons after macros
3c70797 
PR-URL: #27579
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @nodejs-github-bot @ZYSzys @fhinkel @ChALkeR @jasnell @addaleax @BridgeAR