assert: add compatibility for older Node.js versions #27672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the `AssertionError` still accepts the `stackStartFunction` option as alternative to the `stackStartFn`. Fixes: nodejs#27671
nodejs-github-bot
added
the
assert
ZYSzys
approved these changes
May 13, 2019
antsmartian
approved these changes
May 13, 2019
antsmartian
added
the
author ready
addaleax
approved these changes
May 13, 2019
Trott
approved these changes
May 13, 2019
|
lgtm. |
lpinca
approved these changes
May 14, 2019
trivikr
approved these changes
May 15, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 16, 2019
This makes sure the `AssertionError` still accepts the `stackStartFunction` option as alternative to the `stackStartFn`. PR-URL: nodejs#27672 Fixes: nodejs#27671 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in e632b1b 🎉 |
targos
pushed a commit
that referenced
this pull request
May 17, 2019
This makes sure the `AssertionError` still accepts the `stackStartFunction` option as alternative to the `stackStartFn`. PR-URL: #27672 Fixes: #27671 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the
AssertionErrorstill accepts thestackStartFunctionoption as alternative to thestackStartFn.Fixes: #27671
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes