Skip to content

code cleanup #28189

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

code cleanup #28189

wants to merge 2 commits into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Jun 12, 2019
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@joyeecheung joyeecheung mentioned this pull request Jun 16, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24078/

@ZYSzys
Copy link
Member

ZYSzys commented Jul 2, 2019

Landed in 9868126...83c1e17.

@ZYSzys ZYSzys closed this Jul 2, 2019
targos pushed a commit that referenced this pull request Jul 20, 2019
@gengjiawen @targos
build: change ASM compiler url to https
e4fae24 
PR-URL: #28189
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@gengjiawen @targos
src: remove redundant return
e610c45 
PR-URL: #28189
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @nodejs-github-bot @ZYSzys @jasnell @Trott @cjihrig @BridgeAR