[v10.x] console: add trace-events for time and count #28840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
console
BethGriggs
approved these changes
Jul 24, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
andrewhughes101
force-pushed
the
backport-23703-to-v10.x
branch
from
31dae9a to
f0d8b52
Compare
trivikr
approved these changes
Oct 16, 2019
richardlau
approved these changes
Oct 16, 2019
jasnell
approved these changes
Oct 16, 2019
This comment has been minimized.
This comment has been minimized.
MylesBorins
force-pushed
the
v10.x-staging
branch
from
99915bc to
8f3b8ca
Compare
Merged
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29344/ Only failure was |
|
@andrewhughes101, based on the history of this test on v10.x I think the module count number should be incremented by 1 in |
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: nodejs#23703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
andrewhughes101
force-pushed
the
backport-23703-to-v10.x
branch
from
f0d8b52 to
a9c11c9
Compare
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29534/ ✅ - CI is known OSX failures from adding 10.15 |
BethGriggs
pushed a commit
that referenced
this pull request
Mar 9, 2020
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: #23703 Backport-PR-URL: #28840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in b164a2e |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
node.consoletrace event category to captureconsole.count(),console.countReset(),console.time(),console.timeLog(), andconsole.timeEnd()to the traceevent log.
PR-URL: #23703
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Richard Lau riclau@uk.ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes