Skip to content

Fix code example in events API docs #2896

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix code example in events API docs #2896

wants to merge 1 commit into from

Conversation

dgerber
Copy link

@dgerber dgerber commented Sep 16, 2015

No description provided.

@brendanashworth brendanashworth added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 16, 2015
@evanlucas
Copy link
Contributor

This was actually one of the changes from 0.10. require('events') now returns an EventEmitter

Fishrock123
Fishrock123 reviewed Sep 16, 2015
View reviewed changes
doc/api/events.markdown
@@ -23,7 +23,7 @@ attached to.
Use `require('events')` to access the EventEmitter class.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this line, directly above. This was changed ages ago. :)

@Fishrock123
Copy link
Contributor

Thanks for the contribution though, hopefully you'll find something else to contribute! :)

@dgerber
Copy link
Author

dgerber commented Sep 16, 2015

Sorry, still using v0.10...
Then you may want to change that part of the docs which still reads:

const EventEmitter = require('events').EventEmitter;

@evanlucas
Copy link
Contributor

Yes we probably should. I feel that would be acceptable

@Fishrock123
Copy link
Contributor

@dgerber yes, would you mind to make a PR for that? :)

thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Sep 16, 2015
@thefourtheye
doc: remove usage of events.EventEmitter
990659c 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: nodejs#2896
@thefourtheye thefourtheye mentioned this pull request Sep 16, 2015
Closed
thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Sep 17, 2015
@thefourtheye
lib,src: remove usage of events.EventEmitter
705ff31 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: nodejs#2896
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
doc: remove usage of events.EventEmitter
7953c83 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: #2896

PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
lib,src: remove usage of events.EventEmitter
f32a606 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: #2896

PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye @rvagg
doc: remove usage of events.EventEmitter
43e2b7f 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: #2896

PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye @rvagg
lib,src: remove usage of events.EventEmitter
1860e0c 
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.

Refer: #2896

PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@s4sc s4sc mentioned this pull request Nov 30, 2023
Open
@AyushG3112 AyushG3112 mentioned this pull request Nov 30, 2023
Open
@thakursachin467 thakursachin467 mentioned this pull request Nov 30, 2023
Open
@erdun erdun mentioned this pull request Nov 30, 2023
Open
@olegnn olegnn mentioned this pull request Nov 30, 2023
Open
@RoeeOren RoeeOren mentioned this pull request Nov 30, 2023
Open
@GregorFendt GregorFendt mentioned this pull request Nov 30, 2023
Open
@timzwit timzwit mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@solebox solebox mentioned this pull request Nov 30, 2023
Open
@RickAllMighty8195 RickAllMighty8195 mentioned this pull request Feb 11, 2024
Open
@Megoy-Tambayan Megoy-Tambayan mentioned this pull request Feb 11, 2024
Open
@Dixiejane Dixiejane mentioned this pull request Feb 11, 2024
Open
@JCsomeShots JCsomeShots mentioned this pull request Feb 11, 2024
Open
@jj-crypto jj-crypto mentioned this pull request Feb 11, 2024
Open
@ZRDK ZRDK mentioned this pull request Feb 11, 2024
Open
@buzzlightyear726 buzzlightyear726 mentioned this pull request Feb 11, 2024
Open
@Renukaloch Renukaloch mentioned this pull request Feb 11, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Feb 11, 2024
Open
@davidmather davidmather mentioned this pull request Feb 11, 2024
Open
@mrod0101 mrod0101 mentioned this pull request Feb 11, 2024
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Feb 11, 2024
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Feb 11, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Feb 11, 2024
Open
@zhangpan0907 zhangpan0907 mentioned this pull request Feb 11, 2024
Open
@Supermajestcd Supermajestcd mentioned this pull request Feb 12, 2024
Open
@MatheusKael MatheusKael mentioned this pull request Feb 12, 2024
Open
@SanchitMahajan236 SanchitMahajan236 mentioned this pull request Feb 12, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Feb 12, 2024
Open
@myvali998 myvali998 mentioned this pull request Feb 12, 2024
Open
@ambai ambai mentioned this pull request Feb 12, 2024
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Feb 12, 2024
Open
@BryanLaura BryanLaura mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@jefeaguila jefeaguila mentioned this pull request Feb 12, 2024
Open
@Michaela813 Michaela813 mentioned this pull request Feb 12, 2024
Open
@chrismilleruk chrismilleruk mentioned this pull request Feb 12, 2024
Open
@Michaela813 Michaela813 mentioned this pull request Feb 12, 2024
Open
@JoanKalanzi1 JoanKalanzi1 mentioned this pull request Feb 12, 2024
Open
@BryanLaura BryanLaura mentioned this pull request Feb 12, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgerber @evanlucas @Fishrock123 @brendanashworth