doc: simply wording in n-api doc #29441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify/clarify wording documenting n-api execute callback.
nodejs-github-bot
added
doc
gengjiawen
approved these changes
Sep 4, 2019
richardlau
approved these changes
Sep 4, 2019
trivikr
approved these changes
Sep 5, 2019
|
s/simply/simplify/ in the commit message |
Trott
reviewed
Sep 5, 2019
Trott
reviewed
Sep 5, 2019
Trott
approved these changes
Sep 5, 2019
cjihrig
approved these changes
Sep 5, 2019
lpinca
approved these changes
Sep 5, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott
added
the
author ready
|
Landed in bbcbce6 |
Trott
pushed a commit
that referenced
this pull request
Sep 7, 2019
Simplify/clarify wording documenting n-api execute callback. PR-URL: #29441 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Simplify/clarify wording documenting n-api execute callback. PR-URL: #29441 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Sep 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify/clarify wording documenting n-api execute
callback.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes