Skip to content

perf_hooks: remove GC callbacks on zero observers count #29444

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf_hooks: remove GC callbacks on zero observers count #29444

wants to merge 1 commit into from

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Sep 4, 2019

When all existed PerformanceObserver instances removed for type gc GC
callbacks should be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Not sure how add tests for this, any ideas?

@fanatid
perf_hooks: remove GC callbacks on zero observers count
d2915e2 
When all existed PerformanceObserver instances removed for type `gc` GC
callbacks should be removed.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Sep 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25379/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25382/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25383/

@Trott
Copy link
Member

Trott commented Sep 7, 2019

Landed in 6d01f1f

@Trott Trott closed this Sep 7, 2019
Trott pushed a commit that referenced this pull request Sep 7, 2019
@fanatid @Trott
perf_hooks: remove GC callbacks on zero observers count
6d01f1f 
When all existed PerformanceObserver instances removed for type `gc` GC
callbacks should be removed.

PR-URL: #29444
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@fanatid fanatid deleted the perfhooks-gc-callbacks branch September 7, 2019 14:06
targos pushed a commit that referenced this pull request Sep 20, 2019
@fanatid @targos
perf_hooks: remove GC callbacks on zero observers count
9b4a49c 
When all existed PerformanceObserver instances removed for type `gc` GC
callbacks should be removed.

PR-URL: #29444
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fanatid @nodejs-github-bot @Trott @addaleax @JungMinu