build: don't indent assignments in Makefile #29623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indented assignment in a Makefile can be interpreted as a command in e.g. GNU Make 3.81 which results in the following error: ``` make: CPPLINT_QUIET: No such file or directory ```
nodejs-github-bot
added
the
build
sam-github
approved these changes
Sep 20, 2019
richardlau
approved these changes
Sep 20, 2019
lpinca
approved these changes
Sep 20, 2019
benjamingr
approved these changes
Sep 20, 2019
cjihrig
approved these changes
Sep 20, 2019
trivikr
approved these changes
Sep 21, 2019
trivikr
added
the
author ready
|
Landed in 54a0553 |
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
Indented assignment in a Makefile can be interpreted as a command in e.g. GNU Make 3.81 which results in the following error: ``` make: CPPLINT_QUIET: No such file or directory ``` PR-URL: #29623 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
Indented assignment in a Makefile can be interpreted as a command in e.g. GNU Make 3.81 which results in the following error: ``` make: CPPLINT_QUIET: No such file or directory ``` PR-URL: #29623 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Indented assignment in a Makefile can be interpreted as a command in e.g. GNU Make 3.81 which results in the following error: ``` make: CPPLINT_QUIET: No such file or directory ``` PR-URL: #29623 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indented assignment in a Makefile can be interpreted
as a command in e.g. GNU Make 3.81 which results in the
following error:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes