vm: add Synthetic modules #29864
Closed
vm: add Synthetic modules #29864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
added
vm
nodejs-github-bot
added
the
lib / src
devsnek
force-pushed
the
more-vm-shenanigans
branch
from
d3a8f85 to
99f84f0
Compare
devsnek
removed
the
lib / src
devsnek
force-pushed
the
more-vm-shenanigans
branch
3 times, most recently
from
c396c6e to
20ee326
Compare
vsemozhetbyt
reviewed
Oct 7, 2019
addaleax
reviewed
Oct 7, 2019
targos
reviewed
Oct 8, 2019
targos
reviewed
Oct 8, 2019
| added: REPLACEME | ||
| --> | ||
|
|
||
| * `name` {string} Name of the export to set. |
There was a problem hiding this comment.
What happens if name was not listed in exportNames?
There was a problem hiding this comment.
the spec says a ReferenceError is thrown but V8 currently aborts. I posted about it on the bug tracker yesterday so hopefully it will be fixed soon.
devsnek
force-pushed
the
more-vm-shenanigans
branch
3 times, most recently
from
3b8872d to
380891b
Compare
- Refactor vm.SourceTextModule (again) - Add vm.Module abstract superclass - Add vm.SyntheticModule Refs: https://heycam.github.io/webidl/#synthetic-module-records
devsnek
force-pushed
the
more-vm-shenanigans
branch
from
380891b to
baf46f6
Compare
|
@nodejs/vm |
Trott
added
the
author ready
Trott
pushed a commit
that referenced
this pull request
Oct 14, 2019
- Refactor vm.SourceTextModule (again) - Add vm.Module abstract superclass - Add vm.SyntheticModule Refs: https://heycam.github.io/webidl/#synthetic-module-records PR-URL: #29864 Reviewed-By: Guy Bedford <guybedford@gmail.com>
|
Landed in f9caee9 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://heycam.github.io/webidl/#synthetic-module-records
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes