-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: remove extra process.exit() #29873
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit removes it.
Fishrock123
approved these changes
Oct 7, 2019
addaleax
approved these changes
Oct 7, 2019
richardlau
approved these changes
Oct 7, 2019
lpinca
approved these changes
Oct 7, 2019
ZYSzys
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe we should remove those process.exit()
too ?
node/test/parallel/test-http-localaddress.js
Lines 50 to 53 in 064e111
res.on('end', () => { | |
server.close(); | |
process.exit(); | |
}); |
node/test/parallel/test-https-localaddress.js
Lines 62 to 65 in 064e111
res.on('end', function() { | |
server.close(); | |
process.exit(); | |
}); |
BridgeAR
approved these changes
Oct 9, 2019
danbev
pushed a commit
that referenced
this pull request
Oct 10, 2019
process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit removes it. PR-URL: #29873 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in 7682874. |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 10, 2019
process.exit() has a tendency to hide test failures because it forces the process to exit. This test doesn't need the process.exit(), so this commit removes it. PR-URL: #29873 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
2 tasks
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 11, 2019
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: nodejs#29873 (review)
Trott
pushed a commit
that referenced
this pull request
Oct 13, 2019
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 14, 2019
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this during the review of #29816.
process.exit()
has a tendency to hide test failures because it forces the process to exit. This test doesn't need theprocess.exit()
, so this commit removes it.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes