lib/timers.js: replace var with let/const #30404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
timers
jasnell
added
the
code-and-learn
jasnell
approved these changes
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
| @@ -118,7 +118,7 @@ function setTimeout(callback, after, arg1, arg2, arg3) { | |||
| throw new ERR_INVALID_CALLBACK(callback); | |||
| } | |||
|
|
|||
| var i, args; | |||
| let i, args; | |||
There was a problem hiding this comment.
nit: move i to line 135?
for (let i = 5; i < arguments.length; i++) {| @@ -164,7 +164,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) { | |||
| throw new ERR_INVALID_CALLBACK(callback); | |||
| } | |||
|
|
|||
| var i, args; | |||
| let i, args; | |||
There was a problem hiding this comment.
nit: move i to line 181?
for (let i = 5; i < arguments.length; i++) {| @@ -248,7 +248,7 @@ function setImmediate(callback, arg1, arg2, arg3) { | |||
| throw new ERR_INVALID_CALLBACK(callback); | |||
| } | |||
|
|
|||
| var i, args; | |||
| let i, args; | |||
There was a problem hiding this comment.
nit: move i to line 264?
for (let i = 4; i < arguments.length; i++) {
BridgeAR
approved these changes
Nov 13, 2019
gireeshpunathil
approved these changes
Nov 16, 2019
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 24, 2019
PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
landed in ee81bce, thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes