doc: address nits for src/README.md #30693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
richardlau
reviewed
Nov 28, 2019
|
Partial duplicate of #30662. |
richardlau
reviewed
Nov 28, 2019
|
Ah, sorry. Git will rebase out your changes anyway (out of this PR) as they match 1:1, so I think this is still okay. |
cjihrig
approved these changes
Nov 28, 2019
gengjiawen
approved these changes
Nov 28, 2019
trivikr
approved these changes
Nov 28, 2019
benjamingr
approved these changes
Nov 28, 2019
addaleax
added a commit
that referenced
this pull request
Nov 30, 2019
Refs: #30552 (review) PR-URL: #30693 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 0f42727 |
addaleax
added a commit
that referenced
this pull request
Nov 30, 2019
Refs: #30552 (review) PR-URL: #30693 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 5, 2019
Refs: #30552 (review) PR-URL: #30693 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Refs: #30552 (review) PR-URL: #30693 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #30552 (review)
@vsemozhetbyt
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes