Skip to content

tools: update remark-preset-lint-node to 1.11.0 #30789

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

tools: update remark-preset-lint-node to 1.11.0 #30789

merged 1 commit into from
Dec 6, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 4, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 4, 2019
@Trott
Copy link
Member Author

Trott commented Dec 4, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4100/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2019
@Trott
tools: update remark-preset-lint-node to 1.11.0
09ea00b 
PR-URL: nodejs#30789
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 6, 2019

Landed in 09ea00b

@Trott Trott merged commit 09ea00b into nodejs:master Dec 6, 2019
@Trott Trott deleted the preset-1.11.0 branch December 6, 2019 15:12
targos pushed a commit that referenced this pull request Dec 9, 2019
@Trott @targos
tools: update remark-preset-lint-node to 1.11.0
2b687af 
PR-URL: #30789
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@Trott @targos
tools: update remark-preset-lint-node to 1.11.0
eb8f19a 
PR-URL: #30789
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
tools: update remark-preset-lint-node to 1.11.0
1f138f3 
PR-URL: #30789
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@antsmartian antsmartian antsmartian approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @antsmartian @targos @richardlau @BridgeAR @trivikr @nodejs-github-bot