test: get lib/wasi.js coverage to 100% #31039
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit covers the last remaining uncovered code in lib/wasi.js.
BridgeAR
approved these changes
Dec 20, 2019
lpinca
approved these changes
Dec 20, 2019
Trott
approved these changes
Dec 21, 2019
richardlau
approved these changes
Dec 21, 2019
ZYSzys
approved these changes
Dec 22, 2019
cjihrig
added
the
author ready
targos
approved these changes
Dec 22, 2019
Qard
approved these changes
Dec 22, 2019
|
Landed in 5707ed2 |
Trott
pushed a commit
that referenced
this pull request
Dec 23, 2019
This commit covers the last remaining uncovered code in lib/wasi.js. PR-URL: #31039 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
This commit covers the last remaining uncovered code in lib/wasi.js. PR-URL: #31039 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
This commit covers the last remaining uncovered code in lib/wasi.js. PR-URL: #31039 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
This commit covers the last remaining uncovered code in lib/wasi.js. PR-URL: #31039 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit covers the last remaining uncovered code in
lib/wasi.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes