-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
tools: update ESLint to 6.8.0 #31044
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESLint to 6.8.0
BridgeAR
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Trott
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
trivikr
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
ZYSzys
approved these changes
Dec 21, 2019
Qard
approved these changes
Dec 22, 2019
Landed in 5a0cd93 |
Trott
pushed a commit
that referenced
this pull request
Dec 23, 2019
Update ESLint to 6.8.0 PR-URL: #31044 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Update ESLint to 6.8.0 PR-URL: #31044 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Update ESLint to 6.8.0 PR-URL: #31044 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Update ESLint to 6.8.0 PR-URL: #31044 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESLint to 6.8.0
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes